Query regarding MatchType And breakOnMatch

Question

Query regarding MatchType And breakOnMatch

CasperOm opened this issue 2 years ago · comments

Hi @marcosbarbero, hope you are doing good.

I was using 1.7 version of rate limit and now i have upgraded to spring boot 2.x and so the rate limit version to 2.0 but now it has started to show error "httpmethod" is not found in RateLimitProperties$Policy$MatchType: and similar error for break-on-match.

Could you please help how is it handled in latest version? and how can we rate limit for particular httpmethod and multiple limits for a service without using break-on-match.

Thanks in advance

Marcos Barbero · Answer 1 · Mon May 23 2022 23:35:22 GMT+0800 (China Standard Time)

Hi @CasperOm, the httpmethod property was deprecated long ago, you should use http_method instead.
The break-on-match property should still work though.

Om Bhayani · Answer 2 · Tue May 24 2022 14:49:34 GMT+0800 (China Standard Time)

Hi @marcosbarbero , it showing below error for http_method

Description:

Failed to bind properties under 'zuul.ratelimit.policy-list.adminservice[0].type[2]' to com.marcosbarbero.cloud.autoconfigure.zuul.ratelimit.config.properties.RateLimitProperties$Policy$MatchType:

Property: zuul.ratelimit.policy-list.adminservice[0].type[2]
Value: http_method=options
Origin: class path resource [application.yml]:102:11
Reason: failed to convert java.lang.String to com.marcosbarbero.cloud.autoconfigure.zuul.ratelimit.config.properties.RateLimitProperties$Policy$MatchType

Action:

Update your application's configuration
}

AND for break-on-match it showing below error

Unknown property 'break-on-match' for type 'com.marcosbarbero.cloud.autoconfigure.zuul.ratelimit.config.properties.RateLimitProperties.Policy'

Marcos Barbero · Answer 3 · Tue May 24 2022 16:10:31 GMT+0800 (China Standard Time)

I see. I overlook the version you are using of this library.

So, the httpmethod is still the same in the version 2.0.0.RELEASE, and the break-on-match should work.
Can you create a public repo reproducing the issue so that I can take a look?

Om Bhayani · Answer 4 · Tue May 24 2022 22:09:30 GMT+0800 (China Standard Time)

This is the code added in application.yml

zuul:
ratelimit:
enabled: true
behind-proxy: true
repository: JPA
policy-list:
adminService:
- limit: 1000
refresh-interval: 60
type:
- user=anonymous
- origin
- httpmethod=options
break-on-match: true
- limit: 30
refresh-interval: 60
type:
- user=anonymous
- origin
break-on-match: true

and in jar file below is the snippet for RateLimitProperties class and in this class there is no type mentioned as httpmethod

Marcos Barbero · Answer 5 · Tue May 24 2022 22:11:54 GMT+0800 (China Standard Time)

I'm sorry, I need an executable project to reproduce the behavior.

Om Bhayani · Answer 6 · Wed May 25 2022 03:05:10 GMT+0800 (China Standard Time)

Hi @marcosbarbero , here is the executable project.
https://github.com/CasperOm/zuulServer.git

Om Bhayani · Answer 7 · Wed May 25 2022 14:12:58 GMT+0800 (China Standard Time)

Hi @marcosbarbero, I have updated the code pls take latest checkout

Marcos Barbero · Answer 8 · Mon May 30 2022 16:12:12 GMT+0800 (China Standard Time)

Hi @CasperOm I still didn't have time to look into it, I'll try to take a look at your repo later today. I'll keep you posted!
Thanks for providing a working example.

Om Bhayani · Answer 9 · Mon May 30 2022 21:11:00 GMT+0800 (China Standard Time)

Hi @marcosbarbero
Sure. Thanks !

Om Bhayani · Answer 10 · Sat Jun 04 2022 01:46:59 GMT+0800 (China Standard Time)

Hi @marcosbarbero Did you get a chance to look into this?

github-actions · Answer 11 · Mon Jul 04 2022 10:14:04 GMT+0800 (China Standard Time)

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 1 day