Missing targets
james-yeoman opened this issue · comments
According to the esbuild docs, IE and Opera are supported targets, but SUPPORTED_ESBUILD_TARGETS doesn't contain IE nor Opera.
Also, Samsung Internet is chromium-based, so could be mapped.
They added them recently, are you willing to make a PR?
Sure
@marcofugaro is it ok if I add a tweak in my PR? Or should I make it a separate PR?
You've currently got browserslist listed as a dependency, which means that even if people use a different browserslist (e.g. if browserslist updates and they have the latest browserslist), browserslist-to-esbuild will still be using the old definitions.
Also, the tests are failing, even when I do npm ci
EDIT: nvm about the tests, that was just because of the shifting that occurs when including IE and Opera
Oh yeah you're right, browserslist should be a peerDependency.
Yes, different PR if you can, thanks
I've added Opera and IE support in c793735.
However I've decided not to support Samsung Internet since esbuild doesn't support it.
Also it's not a 1:1 conversion to the Chrome browser regarding features, for this reason the solution you implemented in #5 may lead to some confusion.
I'll add support for it if esbuild does though!