Wrong name of .gschema.xml
doppelhelix opened this issue · comments
Right now the filename is
org.gnome.shell.extensions.quicksettings-audio-devices-renamer.gschema.xml
Wouldn't it be better to rename it to
org.gnome.shell.extensions.peek-top-bar-on-fullscreen.gschema.xml?
Hi @doppelhelix, thanks for spotting that. Actually, this file can just be completely removed, since it is needed only for defining configuration options. This extension is not configurable in any way at the moment, so it can just go. This file, together with a bunch of others, has been copied from Audio Devices Renamer, to skip the tedious process of creating everything from scratch.
If you want, feel free to submit a PR that removes that file. Otherwise, I'll do it sometime later.
Since I do not know anything about npm and the underlying build-process, I do not dare to make a PR.
I stumbled upon this only because my PKGBUILD script is parsing the metadata.json for the gschema.xml
@doppelhelix The only thing to do in the PR would be the removal of this file. No need to touch the package.json. The commands there are generic, and don't need to be changed. If there is no schema, it will just not compile it, and it's totally fine.
ok
I feared as much
> peek-top-bar-on-fullscreen@1.0.0 build
> glib-compile-schemas resources/schemas/ && npm run clean && rollup -c && npm run lint-dist
Error opening directory “resources/schemas/”: No such file or directory
It should be fine now, empty directories will not be fetched, I added a keeper file there, and it should be alright
No schema files found: doing nothing.
Thanks a lot
@doppelhelix, fyi, in the end I removed the schemas directory entirely since I got such request during extension review on extensions.gnome.org/.