Giters

marcelog / PAMI

PHP Asterisk Manager Interface ( AMI ) supports synchronous command ( action )/ responses and asynchronous events using the pattern observer-listener. Supports commands with responses with multiple events. Very suitable for development of operator consoles and / or asterisk / channels / peers monitoring through SOA, etc

Home Page:http://marcelog.github.com/PAMI

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Change private properties to protected in `ClientImpl`

alexmnv opened this issue · comments

commented

Why make the properties of ClientImpl private? For example, I need to get an underlying socket to use it in reactphp's event-loop. Given that socket property is private and there's no getSocket function, I can't get it in any other way than modifying the source code of ClientImpl directly (which isn't good practice). If socket were protected, I could just extend the class to implement getSocket function.

commented

Thought it would be better just to implement getSocket() method, so I created a pull request #169