Giters

mapillary / mapillary-js

Interactive, extendable street imagery map experiences in the browser, powered by WebGL

Home Page:https://mapillary.github.io/mapillary-js

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Mapillary JS viewer - Image Distortion - Failed to cache spatial edges

johnaidenrohde opened this issue · comments

commented

Basic information

Mapillary JS viewer occasionally fails to render images in a very interesting way. A refresh corrects the behavior so this is not a critical bug, but it certainly doesn't look great.

mapillary_viewing_issue_2

This bug was encountered by Safety in Numbers analysts and has only been seen on our system to date. I haven't had time yet to setup a clean Mapillary JS instance and confirm the behavior.

MapillaryJS version: v4.0.0
System/Browser: Google Chrome Version 96.0.4664.45 (Official Build) (64-bit)

Steps to Reproduce Behavior

  1. Open the Mapillary JS implementation on map.safe7y.com
  2. Open any Mapillary sequence by selecting a green dot on the map
  3. Hit the >, play button, on the Mapillary JS viewer
  4. Continue to play through sequences until the error occurs - sometimes in as few as 5 images, sometimes after several thousand images

Expected behavior

Images should continue to load without distortion.

Actual behavior

Images become "crumpled" progressively, eventually (within about 10 new image loads) becoming too distorted to see.

Additional information

These screenshots show the progression.

mapillary_viewing_issue_0

mapillary_viewing_issue_1

mapillary_viewing_issue_2

Each time a distorted image is loaded the following console output is received.

mapillary.module.js:85439 
Failed to cache image (500969357710199). TypeError: Cannot read properties of null (reading 'pipe')
    at hy.cacheAssets$ (chunk-vendors.843f91ed.js:22)
    at e.project (chunk-vendors.843f91ed.js:38)
    at e._tryNext (chunk-vendors.843f91ed.js:22)
    at e._next (chunk-vendors.843f91ed.js:22)
    at e.next (chunk-vendors.843f91ed.js:22)
    at e._next (chunk-vendors.843f91ed.js:22)
    at e.next (chunk-vendors.843f91ed.js:22)
    at e._next (chunk-vendors.843f91ed.js:22)
    at e.next (chunk-vendors.843f91ed.js:22)
    at e.next (chunk-vendors.843f91ed.js:22)
(anonymous) @ mapillary.module.js:85439

mapillary.module.js:56445 
Failed to cache spatial edges. TypeError: Cannot read properties of null (reading 'pipe')
    at hy.cacheAssets$ (chunk-vendors.843f91ed.js:22)
    at e.project (chunk-vendors.843f91ed.js:38)
    at e._tryNext (chunk-vendors.843f91ed.js:22)
    at e._next (chunk-vendors.843f91ed.js:22)
    at e.next (chunk-vendors.843f91ed.js:22)
    at e._next (chunk-vendors.843f91ed.js:22)
    at e.next (chunk-vendors.843f91ed.js:22)
    at e._next (chunk-vendors.843f91ed.js:22)
    at e.next (chunk-vendors.843f91ed.js:22)
    at e.next (chunk-vendors.843f91ed.js:22)

Thank you!

commented

Hi @johnaidenrohde, thanks for reporting.

This seems to be the same issue experienced in Firefox reported in #462. Let's keep both issues open for now.

Great information regarding steps to reproduce and error logs. We will try to reproduce and fix.