mapbox / react-colorpickr

A themeable colorpicker with HSL and RGB support for React

Home Page:https://labs.mapbox.com/react-colorpickr/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

react-colorpickr should manage less state

tristen opened this issue · comments

Right now react-colorpickr manages a few things in state that it doesn't necessarily need to. One is value. But value can also be passed as a prop. I wonder if the value of the colorpickr should always be passed back to it as props? cc/ @davidtheclark if you had any thoughts on this.

I wonder if the value of the colorpickr should always be passed back to it as props?

I think that'd be a worthy breaking change — making this a controlled input, instead of an uncontrolled one.