React.PropTypes not compatible with React 16

Question

React.PropTypes not compatible with React 16

aparlato opened this issue 7 years ago · comments

React.PropTypes is not compatible with React 16 which no longer gives a warning about this being deprecated like 15, but actually errors on it.

This should be replaced with prop-types module.

https://github.com/mapbox/react-colorpickr/blob/mb-pages/dist/inputs/number-input.js#L32-L36
(appears in other places as well)

M-ZubairAhmed · Answer 1 · Thu Sep 28 2017 17:49:02 GMT+0800 (China Standard Time)

can I take this issue , and work on migration to PropTypes package?

Tristen Brown · Answer 2 · Thu Sep 28 2017 19:14:21 GMT+0800 (China Standard Time)

@M-ZubairAhmed that would be great!

M-ZubairAhmed · Answer 3 · Wed Oct 04 2017 14:38:26 GMT+0800 (China Standard Time)

i have going through souce code it seems in folder src proptypes as a seperate package is already added. Should i continue to add it in files under dist?

M-ZubairAhmed · Answer 4 · Wed Oct 04 2017 16:34:05 GMT+0800 (China Standard Time)

Please see PR103 is this what you are looking for?