manuelbieh / react-ssr-setup

React Starter Project with Webpack 4, Babel 7, TypeScript, CSS Modules, Server Side Rendering, i18n and some more niceties

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Why is `renderToNodeStream` not used for SSR?

fullofcaffeine opened this issue · comments

Hi!

I see helmet-react-async is being used in the serverRenderer:

import { HelmetProvider } from 'react-helmet-async';

However, React.renderToString - which is blocking - is still being used. Given that helmet-react-async does support it, why not use renderToNodeStream instead?

I don't remember the exact reason but I tried it and ran into several issues. I decided to not spend more time investigating before Suspense gets full server side support, because I do not yet know if renderToNodeStream will still be needed then.

Feel free to experiment and create a PR if you get it running!

I think (not sure though) live reload was broken, which was only one of several issues I had. But that's more than a year ago and I really can't remember anymore.