manthanhd / talkify

Talkify is an open source framework with an aim to standardize and model conversational AI enabling development of personal assistants and chat bots. The mission of this framework is to make developing chat bots and personal assistants as easy as spinning up a simple website in html.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

When using trainAll finished function should be optional

manthanhd opened this issue · comments

Finished function should be optional. Sometimes, you don't care about when the training will finish.

What are the usability implications of this? Does making it optional make it less explicit and hence loosely typed?

It does not make it less explicit. Calling without finishedFunc should return new Error(...) to the caller.

@anubhavsrivastava Yeah that's what I'm debating here. Should it really throw the error or should it just ignore the callback completely?

I find the idea of making callbacks optional similar to how most programming languages make the capturing of return value optional.

ezoic increase your site revenue