Wrong built files mapping when using lastest ECMAScript Modules config in tsconfig.json

Question

Wrong built files mapping when using lastest ECMAScript Modules config in tsconfig.json

hoangngocthanh opened this issue a year ago · comments

Due to https://www.typescriptlang.org/docs/handbook/esm-node.html, it required a full import with file extension when using latest ECMAScript Modules config in tsconfig.json, so it cause a bug that can not expose the XOR declaration.
How to reproduce:
Set: compilerOptions.moduleResolution: "NodeNext" in tsconfig.json

Kostis Maninakis · Answer 1 · Fri Sep 08 2023 20:46:16 GMT+0800 (China Standard Time)

Interesting. Thank you for reporting this!

A quick audit with publint shows no errors and one suggestion:

I wonder if addressing that will fix it or if there's more to it. I definitely want to look more into this.

Kostis Maninakis · Answer 2 · Sun Sep 10 2023 16:38:10 GMT+0800 (China Standard Time)

@hoangngocthanh could you please append the full contents of your tsconfig.json file in your original message?

Kostis Maninakis · Answer 3 · Mon Sep 11 2023 13:43:26 GMT+0800 (China Standard Time)

Should be fixed with v1.1.1. @hoangngocthanh please let me know how that works for you.

Also, any feedback about the new release's compatibility with existing repos importing ts-xor and having different tsconfig configurations would also be appreciated. Tried my best not too, but it's hard to know I haven't introduced a regression with the cjs/esm mess... 🤷‍♂️

Hoàng Ngọc Thành · Answer 4 · Mon Sep 11 2023 14:01:05 GMT+0800 (China Standard Time)

Should be fixed with v1.1.1. @hoangngocthanh please let me know how that works for you.

Also, any feedback about the new release's compatibility with existing repos importing ts-xor and having different tsconfig configurations would also be appreciated. Tried my best not too, but it's hard to know I haven't introduced a regression with the cjs/esm mess... 🤷‍♂️

I find it working well with v1.1.1, thanks for the support!