malcolmocean / beeminderjs

NodeJS wrapper for Beeminder API

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

obligatory node request - promises instead of callbacks

codekiln opened this issue · comments

In my opinion, it would be more compatible with the node ecosystem if the API returned promises rather than using callbacks. This may be achievable with Bluebird.promisifyAll()...

I think a separate package, without CLI interface, would be better for that. I can clean up and publish what I use if anyone else needs it, although it's pretty trivial.

Seeing no activity for almost a year here I doubt that anyone else needs that though.

Just added promise support because I've started using promises on complice.co now, so I had both a personal desire and also a sense of actually knowing what I'm doing in terms of implementing promise support.

(Relevant commit: c692e83)