Should we rename DssDirectDepositHub to D3MHub?

Question

Should we rename DssDirectDepositHub to D3MHub?

gbalabasquer opened this issue 2 years ago · comments

Gonzalo Balabasquer commented 2 years ago

PR: #61

Sam MacPherson · Answer 1 · Sun Jun 05 2022 22:45:26 GMT+0800 (China Standard Time)

I'm good with whatever.

talbaneth · Answer 2 · Mon Jun 06 2022 14:11:28 GMT+0800 (China Standard Time)

This should be done for sure as all the other file names already changed to have the shorter D3M prefix.

talbaneth · Answer 3 · Mon Jun 06 2022 17:30:57 GMT+0800 (China Standard Time)

Also I suggest to rename D3MAaveDai*.sol to just D3MAave*.sol everywhere.
Dai is already one of the three Ds in D3M :).

Gonzalo Balabasquer · Answer 4 · Mon Jun 06 2022 21:10:30 GMT+0800 (China Standard Time)

Ok good I'll address both in a PR.

Sam MacPherson · Answer 5 · Mon Jun 06 2022 21:22:17 GMT+0800 (China Standard Time)

We seem to be gradually making this specific to DAI btw. Originally I called it direct-deposit to keep it agnostic to the asset we are depositing. Maybe that doesn't matter, but something to be aware of.

Gonzalo Balabasquer · Answer 6 · Mon Jun 06 2022 22:20:31 GMT+0800 (China Standard Time)

We seem to be gradually making this specific to DAI btw. Originally I called it direct-deposit to keep it agnostic to the asset we are depositing. Maybe that doesn't matter, but something to be aware of.

I think in that case we probably prefer to make a complete new repo as a different project, as the actual Hub is pure Dai related, for other assets wouldn't exist the concept of creating a CDP.