mail-in-a-box / mailinabox

Mail-in-a-Box helps individuals take back control of their email by defining a one-click, easy-to-deploy SMTP+everything else server: a mail server in a box.

Home Page:https://mailinabox.email/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Don't force port 22 for rsync backup

SoMuchForSubtlety opened this issue · comments

commented

Currently, the backup script has port 22 hardcoded.

"--rsync-options= -e \"/usr/bin/ssh -oStrictHostKeyChecking=no -oBatchMode=yes -p 22 -i /root/.ssh/id_rsa_miab\"",

This prevents setting a non-standard port via ~/.ssh/config and I don't see any upsides since port 22 is the default anyway.

I need to use port 23 since that is what's being used by hetzner storage box.

I have this implemented on a fork of mine - if anyone wants to make a PR you can start by cherry-picking this commit:
ddavness/power-mailinabox@8a0805d

Yeah I can't think of a reason why -p 22 should be there, and I would accept a pull request removing it.

@SoMuchForSubtlety this is merged in 61 and works now, can this be closed?
Thanks.