magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.

Home Page:http://www.magento.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Product Rating: Rating isn't Available in Admin Panel New Review page

hiren-gujarati opened this issue · comments

Preconditions and environment

  • Magento version: 2.4.7 or 2.4.x
  • Create/Assign rating to specific store if not any from Admin > Store > Rating.

Steps to reproduce

  1. Go to Admin > Marketing > All Reviews > New Review > Choose any product
  2. It will show 'Rating isn't Available' for Product Rating field (it is correct because Visibility is not selected yet)
  3. Select Store in Visibility multi-select field.

After select/change Visibility it is not showing Product Ratings every time.

Expected result

It should send ajax request for update rating and show Product Rating every time when user select/change visibility.

image

Actual result

It is not sending ajax request and not showing Product Rating every time. Need to hard refresh multiple time to see Product Rating on select/change of visibility field.

image

Additional information

Due to any reason mentioned JS function is not calling every time on page load and it is causing issue.

https://github.com/magento/magento2/blob/2.4.7/app/code/Magento/Review/Block/Adminhtml/Add.php#L107-L109

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Hi @hiren-gujarati. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

Hi @hiren-gujarati,

Verified the issue on 2.4-develop and 2.4.7 and it is not reproducible.

Steps to reproduce:-

1.Go to Admin > Marketing > All Reviews > New Review >Choose any product
2.It will show 'Rating isn't Available' for Product Rating field (it is correct because Visibility is not selected yet)
3.Select Store in Visibility multi-select field.
4.Verify the behaviour

Please refer the attached screenshot and let us if we are missing something.

Screenshot 2024-04-29 at 9 27 43 PM Screenshot 2024-04-29 at 1 36 30 PM Screenshot 2024-04-29 at 1 55 57 PM Screenshot 2024-04-29 at 1 59 53 PM

After select/change Visibility it is showing Product Ratings every time

Screenshot 2024-04-29 at 9 24 19 PM Screenshot 2024-04-29 at 9 24 39 PM

✅ Jira issue https://jira.corp.adobe.com/browse/AC-11875 is successfully created for this GitHub issue.

@magento give me 2.4-develop instance

Hi @engcom-Delta. Thank you for your request. I'm working on Magento instance for you.

@magento give me 2.4-develop instance

Hi @hiren-gujarati. Thank you for your request. I'm working on Magento instance for you.

Hi @engcom-Delta

As mentions before Rating field is not visible every time so, initially it might work for you but if you navigate to other page and back to new review page then it is not working almost 9 out of 10 times. Please check attached video of this issue, I have tested on above 2.4-develop instance.

38670.webm

Setting the visibility for rating attributes, indeed fixed it for me.
Might be possible, that with the update to 2.4.7 (or even other versions?) the ratings loose their visibility.

@magento give me 2.4-develop instance

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

Hi @hiren-gujarti

Thanks for reporting and collaboration.

Verified the issue on magneto 2.4 dev instance but the issue is still not reproducible.

Steps to reproduce
Go to Admin > Marketing > All Reviews > New Review > Choose any product
It will show 'Rating isn't Available' for Product Rating field (it is correct because Visibility is not selected yet)
Select Store in Visibility multi-select field.

We are able to see the rating.

Please refer the attached screenrecording. Let us know if we missed anything.

Screen.Recording.2024-05-07.at.4.49.21.PM.1.mov