Bug: -d directory contains magefiles directory does not work

Question

turutcrane opened this issue 2 years ago · comments

Bug Description
-d directory contains magefiles directory does not work

What did you do?
$ mage -d DIR target

DIR contains magefiles directory.

What did you expect to happen?
Execute target in DIR/magefiles.

What actually happened?
mage stop with "No .go files marked with the mage build tag in this directory."

Environment

Mage Version:
Mage Build Tool v1.14.0
Build Date: 2022-11-04T21:23:44+09:00
Commit: 300bbc8
built with: go1.19.2
OS: windows msys2 / linux (WSL2)

Additional context
None

Nate Finch · Answer 1 · Fri Nov 04 2022 22:02:22 GMT+0800 (China Standard Time)

Ahh interesting point, yeah, -d should be smart enough to figure out if you have a magefiles directory or not, and use that if it's there.

TuruTCrane · Answer 2 · Sat Nov 05 2022 12:20:37 GMT+0800 (China Standard Time)

I tryed to fix it by PR #448. Please review it.

Horacio Duran · Answer 3 · Fri Feb 24 2023 00:42:30 GMT+0800 (China Standard Time)

Thank you @turutcrane for the fix