magao-x / MagAOX

The MagAO-X Software System

Home Page:https://magao-x.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

app::zaberLowLevel doesn't halt on missing stage

jaredmales opened this issue · comments

or otherwise handle it. If a configured stage isn't found, which can happen if say the stage is in local control or disconnected, zaberLowLevel silently continues but somehow ends up trying to communicate with the missing stage. This causes timeouts and eventual crashes.

there is a check for unknown stages found that aren't configured, but no check for a configured stage not found. it appears that in this case zaberStage::m_deviceAddress will be a random number. We should initialize this to something and check it, and prevent communications in this case.

also need to add the check for configured not found.

checks for missing stage implemented in d7fc194. Needs to be tested with actually missing stage. Can be done by disconnected stagebs

tested.