Giters

mafredri / cdp

Package cdp provides type-safe bindings for the Chrome DevTools Protocol (CDP), written in the Go programming language.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Breaking changes in node js debugging in v0.34.0

yogesh-ti opened this issue · comments

commented

Context

  • The following code which uses devtool to get websocket debugging URL has broken in the v0.34.0 release
    image

  • This is the error
    image

Workaround

  • This piece of code works fine upon changing back the cdp version to 0.33.0
commented

I went through the release notes and found the PR where changes were made but I didn't find any mention of changes required at the user's end. So I'm assuming the changes made don't work with the target devtool.Node

commented

Thanks for reporting @yogesh-ti, can you confirm if #142 fixes the issue?

commented

@mafredri I tried this and it worked. Thanks a lot for this fast addressal of the issue 👍

commented

You're welcome, and thanks for confirming the fix! Fix released in https://github.com/mafredri/cdp/releases/tag/v0.34.1.