Inconsistent hashes in different scenarios
yoshuawuyts opened this issue · comments
It seems that running siphash24 on different OS'es / Node versions can yield different results. This might be because of what we're doing, but given that the output files have been fingerprinted and consistent between versions it seems it might actually be the hashing algo.
The best repro we got at the moment is the Bankai test suite of the new-new-new branch. It yields different hashes between Node 4, and Node 6 and Node 8 (link to Travis).
I'm not sure what's going on, but further investigation would probably be good. Thanks!
Refs
It's definitely us :(
oh bummer, do you have more details? curious
Haha, it's looking like I have some race condition in Bankai when creating bundle.js. I think node 4 was just slow enough that we'd consistently hit it. Digging in further to figure out what's up on our end (: