Giters

madsleejensen / react-native-image-capinsets

adds support for a similar functionality as <Image capInsets={...} /> to android

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[PROPOSAL] Image can't have children. Proposing ImageBackground

cbabos opened this issue · comments

commented

The Android implementation allows adding children which is a great thing I believe.
However the iOS implementation uses Image which simply doesn't allow children.
RN has an ImageBackground implementation by default which also uses Image (so capInsets still available) but also provides using children.

Because of the above I propose to use ImageBackground in ImageCapInsets.ios.js

commented

Will create a Pull Req. soon :)
update: Done.

commented

@madsleejensen Is there a chance you'll have time to check this?