madleech / ArduinoCMRI

Arduino library for connecting your computer to your model railroad.

Out of bound checking leads to buffer overflow

jlbirccyn opened this issue 5 years ago · comments

Jean-Luc Béchennec commented 5 years ago

Hi Michael

At lines https://github.com/madleech/ArduinoCMRI/blob/master/CMRI.cpp#L107, https://github.com/madleech/ArduinoCMRI/blob/master/CMRI.cpp#L115, https://github.com/madleech/ArduinoCMRI/blob/master/CMRI.cpp#L130, test should be >= to prevent out of bound access of the array.

Best regards

Erik commented 3 years ago

There seems to be no response, a pity.
Thank you for that correction, I modified manually.
Erik