Should `acceptPayment` throw an error if the payment is for less than a previous payment?

Question

Should `acceptPayment` throw an error if the payment is for less than a previous payment?

kincaidoneil opened this issue 6 years ago · comments

My understanding is that if the payment is otherwise valid, it persists it to the db, and only when claiming the channel, the receiver checks for the payment with the maximum value.

For our use case, we really need the ability to know what the largest payment/best claim is so we can reject payments for which the value is less than a previous payment.

Is there a way to do that using the current API? Or should acceptPayment throw an error if it's not the greatest payment?

Andrei Riaskóv · Answer 1 · Sat Jul 14 2018 23:50:31 GMT+0800 (China Standard Time)

Hi, @kincaidoneil ! Good suggestion. We plan to realize this check after we'll finish ERC20 support.

Andrei Riaskóv · Answer 2 · Fri Jul 20 2018 03:58:26 GMT+0800 (China Standard Time)

Merged. Thank you very much for contributing!