mabelcalim / waipy

This guide includes a Continuous Wavelet Transform (CWT), significance tests from based on Torrence and Compo (1998) and Cross Wavelet Analysis (CWA) based on Maraun and Kurths(2004).

Home Page:https://wavelet-analysis.readthedocs.org/en/latest/index.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

j1 parameter in wavelet()

m-weigand opened this issue · comments

As far as I can see the j1 parameter is

a) not used anywhere:

waipy/lib/waipy$ grep -R j1 *
cwt/wavetest.app/Contents/Resources/wavetest.py:j1 = 7/dj # this says do 7 powers-of-two with dj sub-octaves each
cwt/wavetest.app/Contents/Resources/wavetest.py:ondaleta,wave,period,scale,coi = lib_wavelet.wavelet(sst,dt,mother,param)#,pad,dj,s0,j1,mother,param)
cwt/lib_wavelet.py:def wavelet(Y, dt, param, dj, s0, j1, mother):
cwt/wavetest.py:def wavelet(Y, dt, param, dj, s0, j1, mother):
cwt/wavetest.py:def cwt(data, dt, pad, dj, s0, j1, lag1, param, mother, name):
cwt/wavetest.py: j1 = 7/dj # this says do 7 powers-of-two with dj sub-octaves each
cwt/wavetest.py: data, dt, param, dj, s0, j1, mother)
cwt/wavetest.py: 'nw': nw, 'mean_wavelet': mean_wavelet, 'dj': dj, 'j1': j1,
cwt/wavetest_2.7.py:def cwt(data, dt, pad, dj, s0, j1, lag1, param, mother, name):
cwt/wavetest_2.7.py: j1 = 7/dj # this says do 7 powers-of-two with dj sub-octaves each
cwt/wavetest_2.7.py: data, dt, param, dj, s0, j1, mother)
cwt/wavetest_2.7.py: 'nw': nw, 'mean_wavelet': mean_wavelet, 'dj': dj, 'j1': j1,

b) does not have any corresponding equation in Torrence & Compo

Can we thus remove the parameter? If this is the case I will prepare a merge request.