Make quantity a floating point number not an integer.

Question

Make quantity a floating point number not an integer.

rouilj opened this issue a year ago · comments

For invoices that bill by time, --quantity should be a floating point number so 1/2 hour or other
time periods can be specified. Currently using --quantity 0.5 --rate 175 I get:

2023/07/03 23:32:17 invalid argument "0.5" for "-q, --quantity" flag: strconv.Atoi:
  parsing "0.5": invalid syntax

for invoicing a 1/2 hour call.

Thanks.

Yoseph Tanner · Answer 1 · Thu Jul 13 2023 03:08:47 GMT+0800 (China Standard Time)

@rouilj until this is fixed, you can change your rate on items that are qty < 1 to match, for e.g. -q 1 -r 87.5 since -r or --rates DOES support floating/decimals. Then, in the item notes, in parens, you can say (1/2 hrs @ $175/hr = $87.50). Just a work around.

John P. Rouillard · Answer 2 · Thu Jul 13 2023 03:54:53 GMT+0800 (China Standard Time)

In message ***@***.***>, Yoseph Tanner writes:

@rouilj until this is fixed, you can change your rate on items that are qty < 1 to match, for e.g. `-q 1 -r 87.5` since `-r or --rates` DOES support floating/decimals.

Yes that works. However explaining to somebody that the 1/2 hour phone call was billed as an hour phone call at 1/2 the rate is not something I want to deal with.

…

-- -- rouilj John Rouillard =========================================================================== My employers don't acknowledge my existence much less my opinions.

Yoseph Tanner · Answer 3 · Thu Jul 13 2023 04:30:52 GMT+0800 (China Standard Time)

@rouilj you may have responded before I edited my response and added this part Then, in the item notes, in parens, you can say (1/2 hrs @ $175/hr = $87.50). Just a work around.

But trust me, I'm with you on this, take a look at #31 , I said the same things ;)

Yoseph Tanner · Answer 4 · Fri Jul 14 2023 05:58:31 GMT+0800 (China Standard Time)

@rouilj I posted a patch in #31 , you can use go build (if you don't already know) to build it

John P. Rouillard · Answer 5 · Fri Jul 14 2023 07:26:32 GMT+0800 (China Standard Time)

I actually decided to give a shot to learning a little go. So I have my own change for it. But thanks for the pointer. I'll use your pointer to see if my change is idiomatic go.

Yoseph Tanner · Answer 6 · Fri Jul 14 2023 07:42:08 GMT+0800 (China Standard Time)

I actually decided to give a shot to learning a little go. So I have my own change for it. But thanks for the pointer. I'll use your pointer to see if my change is idiomatic go.

LOL, me too. Today is my first day ever writing any GO code. Take a look at #31 I just submitted code for implementing version command, Chinese char support,and the qty change.