m3db / m3

M3 monorepo - Distributed TSDB, Aggregator and Query Engine, Prometheus Sidecar, Graphite Compatible, Metrics Platform

Home Page:https://m3db.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

go mod error

tpinellia opened this issue · comments

go.mod

require (
	github.com/m3db/m3 v1.1.0
	go.etcd.io/etcd/client/v3 v3.5.0
	google.golang.org/grpc v1.40.0
	google.golang.org/protobuf v1.27.1
)

error:

go: finding module for package google.golang.org/grpc/naming
      github.com/m3db/m3/src/dbnode/client imports
        github.com/m3db/m3/src/dbnode/environment imports
        github.com/m3db/m3/src/cluster/client/etcd tested by
        github.com/m3db/m3/src/cluster/client/etcd.test imports
        go.etcd.io/etcd/integration imports
        go.etcd.io/etcd/proxy/grpcproxy imports
        google.golang.org/grpc/naming: module google.golang.org/grpc@latest found (v1.40.0), but does not contain package google.golang.org/grpc/naming

my protobuf reminds me that I need a larger version

// This is a compile-time assertion to ensure that this generated file
// is compatible with the grpc package it is being compiled against.
// Requires gRPC-Go v1.32.0 or later.
const _ = grpc.SupportPackageIsVersion7

but m3 relied on google.golang.org/grpc/naming。so i need to replace the modreplace google.golang.org/grpc => google.golang.org/grpc v1.29.1

how can i fix it?

@tpinellia is there an issue with using v1.29.1? I believe we have some dependencies we haven't sorted out that still require that version.

We need to upgrade grpc past v1.29.1. Are there any plans or efforts underway to make this compatible with grpc v1.30.0 and above (e.g. grpc v1.40.0). This is one of the last dependencies still blocking us from advancing grpc version.