m1entus / INSPhotoGallery

INSPhotoGallery is a modern looking photo gallery written in Swift for iOS.

Home Page:https://medium.com/inspace-labs-blog/insphotogallery-modern-looking-photo-gallery-written-in-swift-for-ios-7c6b3fdf54da

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Can I update background color of INSScalingImageView ?

dproton opened this issue · comments

Currently, INSScalingImageView is declared as internal level and I can't get it ? Can you public it ? Thank you so much

Why you want to get access to it ?

Thanks for your response,
Some images I got from server is transparent background, and INSScalingImageView.backgroundColor == .clear, so the image can't be display

The current one:
simulator screen shot - iphone 6s - 2018-04-10 at 16 06 51

My expectation (and I can do it if I can set INSScalingImageView.backgroundColor)

screen shot 2018-04-10 at 16 07 19

You can subclass and override func initializePhotoViewControllerForPhoto(_ photo: INSPhotoViewable) -> INSPhotoViewController method and INSPhotoViewController have lazy private(set) var scallingImageView property, and then you can set background

But currently, INSPhotosViewController is only public and can't be inherited

Can you open it and create PR ?