Add support for ui-bootstrap 0.14+
NealHaggard opened this issue · comments
They've renamed things including $modal to $uibModal (with 0.14.3 they will also rename $uibModalInstance). Currently it still works using angular-dialog-service 5.2.8, however a warning is given about $modal being deprecated when dialogs is initialized.
Can you please include a pull request for this. I can confirm this behavior.
Added a pull request. https://github.com/m-e-conroy/angular-dialog-service/pull/146/files
@NealHaggard Thanks for your contribution!
Is anyone getting this error?
$modalInstance is now deprecated. Use $uibModalInstance instead.
Have you upgraded your code after using this? dialog-service is now using ui-bootstrap 0.14.3 which will give those messages until you go change $modalInstance to $uibModalInstance (similarly $modal changed to $uibModal). I don't get this in my local usage of angular-dialog-service 5.2.9 with ui-bootstrap 0.14.3.
Yeah, I'm running latest of everything!
https://github.com/exceptionless/Exceptionless.ui
I need to check for usages but I'm about 95% sure I'm not injecting $modalInstance
Just a quick look through your code found this:
Ah thanks :)