lynaghk / cljx

Write a portable codebase targeting Clojure/ClojureScript

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Homogenize hooks with cljsbuild

magomimmo opened this issue · comments

Wouldn't be better to have the same way to hook cljx and cljsbuild to tasks?
Now we have to write:

:hooks [leiningen.cljsbuild cljx.hooks]

IMHO it would be better to write

:hooks [leiningen.cljsbuild leiningen.cljx] 

Fortunately, the great @cemerick is the head maintainer of both projects! All hail @cemerick and the wise decision he might bestow upon us.

@lynaghk is there an eye-rolling emoticon? Also, I thought I was just an interloper here. ;-P

@magomimmo Those symbols are just namespace names. I don't actually think the leiningen prefix on everything is particularly helpful; but, in any case, what you're suggesting would be a breaking change for no benefit.

Chas,
yes, I understand your point. The only benefit would be if any plugin which implements hooks to leiningen task would uses the same way to hook them: less things to remember, but would be even more unfeasible.

On Sep 15, 2013, at 12:57 PM, Chas Emerick notifications@github.com wrote:

@lynaghk is there an eye-rolling emoticon? Also, I thought I was just an interloper here. ;-P

@magomimmo Those symbols are just namespace names. I don't actually think the leiningen prefix on everything is particularly helpful; but, in any case, what you're suggesting would be a breaking change for no benefit.


Reply to this email directly or view it on GitHub.