Missing nREPL middleware in 0.2.2 as available on clojars
jeluard opened this issue · comments
Although documentation indicates the nREPL middleware can be used with version 0.2.2 it is actually not in the jar pushed on clojars.
Maybe a new version should be pushed with this change?
Yeah, I guess I should have kept that on a feature branch. I've pulled the documentation discussing it for now.
@lynaghk can push a new release of master if he's up for it? (Or not, depending on how soon we'll be merging in the sjacket branch?) Anyway, I'll restore the documentation once the bits are on Clojars.
@cemerick How far along is the sjacket stuff? I'm under the impression that'll be wrapped up in a week or two, in which case I would prefer to just wait and do a new release then.
I'd generally agree with holding off on another release, given the planned changes.
@lynaghk Merge-time is really more up to you. FWIW, I've sjacketed two of the four cljx projects I have (my data.generators fork, and another that isn't on github), with good/expected results. (No runtime reading, the results look great [i.e. line/column number correspondence], and the whole thing is way faster than the kibit/core.logic route, which is great when cljx is doing its thing in real-time as part of nREPL middleware.) I'm hoping to transition the other two this coming week.
@jeluard The above is all a bit inside-baseball, but the short of it is that cljx is being significantly refactored to address some of the shortcomings of what's on master now. The code for it is on the sjacket branch; if you want to give it a try, my personal artifact is @ [org.clojars.cemerick/cljx "0.3.0-SNAPSHOT"]. It's be awesome to get some feedback on the changes there.
I spoke too fast, I get an exception when running lein install with cljx.hooks configured. Where should I report this? Your fork has github/issues disabled.
An issue here is fine. I don't use hooks often, thanks for the report!
Closing as wontfix given @lynaghk's comment above. sjacket cljx looks solid, just a couple of loose threads to tie up.