lyft / toasted-marshmallow

S'More speed for Marshmallow

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Propose the hooks upstream

s0undt3ch opened this issue · comments

Has an attempt to add in the required hooks made to the upstream marshmallow project?

The reason I ask this is because if one tries to install a marshmallow plugin, say, marshmallow-jsonschema, it has marshmallow listed as its dependency and will pull that in when installing.
We're then left with an unpredictable situation on which marshmallow library will python import.
If we uninstall it afterward, we end up with something like:

pkg_resources.DistributionNotFound: The 'marshmallow>=2.9.0' distribution was not found and is required by marshmallow-jsonschema

I believe this is already done: marshmallow-code/marshmallow#629

Thanks, following the issue upstream.