Giters

lyft / toasted-marshmallow

S'More speed for Marshmallow

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

PavanTatikonda opened this issue · comments

commented

Hello @rowillia @jmphilli

We are seeing below warnings when we run pytest on marshmallow package which is using below : orderedset.py and utils.py

marshmallow/orderedset.py:26: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
    class OrderedSet(collections.MutableSet):

marshmallow/utils.py:54: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
    (isinstance(obj, collections.Iterable) and not hasattr(obj, "strip")) or is_generator(obj)

I would like to report this issue and would be glad to contribute to fix the issue in forked copy of marshmallow which toastedmarshmallow is using. However, I'm not quite sure if I need to create a PR with the fix to merged into dev branch of lyft/marshmallow or some other branch.

Would you be able to provide the contribution guidelines or any information which helps me understand how I can contribute to this? Once you merge the PR finally then we would need your help in releasing new package of lyft/toasted-marshmallow so we can updated our project to use the new version of this project to resolve the deprecationwarning.

Please let me know if you need any other information.

Thanks for your understanding and cooperation in this matter.

Regards,
Pavan

commented

@rowillia @jmphilli I would love to contribute to this fix and the following issues as well:

https://github.com/lyft/toasted-marshmallow/issues/9
https://github.com/lyft/toasted-marshmallow/issues/14
https://github.com/lyft/toasted-marshmallow/issues/4