lyft / protoc-gen-star

protoc plugin library for efficient proto-based code generation

Home Page:https://godoc.org/github.com/lyft/protoc-gen-star

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Full google.protobuf.SourceCodeInfo?

bufdev opened this issue · comments

I saw you just added comment support from the SourceCodeInfos in 6f176a9, what about extending this to include line and column information? This would be useful, especially in the visitor.

@peter-edge can you explain a use-case in which this would be useful? Now that the parsing methodology is in place it's fairly easy to include this. I can take this one but once we decide a real use-case and an appropriate API for it.

I’m writing a self-contained linter and formatter for protobuf, that right now relies on github.com/emicklei/proto, but using the tried-and-tested proto parser in protoc would be ideal.

I would/might write this myself but don’t want to reinvent the wheel as you all have done such a great job here.