lyft / confidant

Confidant: your secret keeper. https://lyft.github.io/confidant

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix python dist to work with toastedmarshmallow/webargs

ryan-lane opened this issue · comments

toastedmarshmallow includes a fork of marshmallow, but webargs lists marshmallow as a dependency. To fix webarg's dependency resolution, it's necessary to install the marshmallow fork via -e git+..., but that doesn't work for setup.py dependencies.

We're not actively using webargs currently, but some upcoming changes for using marshmallow for API request validation will use webargs. Using marshmallow without toastedmarshmallow has a high performance cost, so we need to figure out a way to make everything play nice.

Adding @rowillia as he made toastedmarshmallow and may have some ideas

For now I'll pull webargs out to fix the build.