lyft / clutch

Extensible platform for infrastructure management

Home Page:https://clutch.sh

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

The Error component isn't nested in the Feedback folder

jpeach opened this issue · comments

Description

Screen Shot 2022-03-09 at 5 11 47 pm

In the storybook screenshot above, the Error component is shown at the same level as the Feedback folder. In the actual source, Error is nested under the "Feedback" directory, but specifies "Core/Error" in its Meta export.

Expected Behavior

On-disk sources should roughly match the component hierarchy to make things easier to find.

This diff convinces storybook to move the component, but I'm not sure whether this has any other effects:

--- frontend/packages/core/src/Feedback/error/stories/error.stories.tsx
+++ frontend/packages/core/src/Feedback/error/stories/error.stories.tsx
@@ -6,7 +6,7 @@ import type { ErrorProps } from "../index";
 import Error from "../index";

 export default {
-  title: "Core/Error",
+  title: "Core/Feedback/Error",
   component: Error,
 } as Meta;

thanks for doing this! :)