lyft / clutch

Extensible platform for infrastructure management

Home Page:https://clutch.sh

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

chaos_experimentation: allow querying for completed experiments

bwitt opened this issue · comments

Description

I'd like to query for only COMPLETED experiments via the GetExperiments call

rpc GetExperiments(GetExperimentsRequest) returns (GetExperimentsResponse) {

My understanding is this would require updating the Request proto here

enum Status {
// Unspecified status.
STATUS_UNSPECIFIED = 0;
// Return experiments that are currently running.
STATUS_RUNNING = 1;
}

and then update the query to the backend db here

` AND ($2 = 'STATUS_UNSPECIFIED' OR (experiment_run.cancellation_time is NULL AND NOW() > lower(experiment_run.execution_time) AND (upper(experiment_run.execution_time) IS NULL OR NOW() < upper(experiment_run.execution_time))))`

Complexity [S/M/L]:

Wireframes, Mockups, or Screenshots (if applicable)