lyfeyaj / jaql

Automatically exported from code.google.com/p/jaql

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Jaqlshell command history does not work in Cygwin

GoogleCodeExporter opened this issue · comments

1. Open a jaqlshell in cygwin. 
2. Input some jaql commands.
2. After hitting UP or DOWM key, command history does not show up.

Original issue reported on code.google.com by yaojingguo@gmail.com on 4 Sep 2009 at 7:50

[deleted comment]
[deleted comment]
[deleted comment]
[deleted comment]
[deleted comment]
[deleted comment]
Hi, Vuk & Kevin

The cause of this issue is the following code in bin/jaqlshell.

if $cygwin; then
 #HADOOP_OPTS="$HADOOP_OPTS -Djline.terminal=jline.UnixTerminal"
 HADOOP_OPTS="$HADOOP_OPTS -Djline.terminal=jline.UnsupportedTerminal"
fi

It is also the cause of Issue 28.

If I delete the above code, jaqlshell command history works in Cygwin. And 
Issue 
28 disappears.

In Cygwin console (not things like xterm running Cygwin), jline will use 
WindowsTerminal. 

If removing the same code in jaql-0.4, we have the same effect. But there is
another issue. After issuing quit;, the jaqlshell hangs. It will not quit even
though I hit CTRL-C. The possible reason is  Issue 29 . Since I have fixed
Issue 29  in jaql svn trunk,  jaqlshell of jaql svn trunk does not have this 
problem. 

If you think that my fix is OK, I will commit my code and close this issue.

Original comment by yaojingguo@gmail.com on 5 Sep 2009 at 3:29

this change looks fine, please commit it.

Original comment by vuk.erce...@gmail.com on 18 Sep 2009 at 1:17

Fixed in Revision 320.

Original comment by yaojingguo@gmail.com on 18 Sep 2009 at 4:29

  • Changed state: Fixed