Giters

lwjglgamedev / vulkanbook

Online book which introduces the main concepts required to write graphics games or any other applications using Vulkan in Java by using the LWJGL library.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Chapter 13 issues

rongcuid opened this issue · comments

commented
  1. Might be good to mention that CascadeShadow is in the graph.shadows package
  2. Double paste: VkRenderPassCreateInfo renderPassInfo = VkRenderPassCreateInfo.calloc(stack) renderPassInfo = VkRenderPassCreateInfo renderPassInfo = VkRenderPassCreateInfo.calloc(stack).calloc(stack)
  3. Change to LightingFrameBuffer::createFrameBuffers doesn't actually change anything in book
  4. Code in GLSL is listed incorrectly
  5. Mention removal of updateInvMatrices in constructor of LightingRenderActivity
  6. The call geometryRenderActivity.recordCommandBuffer(commandBuffer, meshList, scene); and a few others doesn't actually have the scene parameter
  7. Mention constructor changes in Render class
commented

Thanks for reprting!

Just some questions:

  1. Code in GLSL is listed incorrectly
    Can you calrify what do you mean by this?
  1. Mention constructor changes in Render class
    I think this is already mentioned. Can you please clarify this?
commented

4, markdown format issue:

Screenshot 2022-12-28 at 10 35 19 AM

Unfortunately, I forgot what I meant by 7...