Chapter 13 issues
rongcuid opened this issue · comments
- Might be good to mention that
CascadeShadow
is in thegraph.shadows
package - Double paste:
VkRenderPassCreateInfo renderPassInfo = VkRenderPassCreateInfo.calloc(stack) renderPassInfo = VkRenderPassCreateInfo renderPassInfo = VkRenderPassCreateInfo.calloc(stack).calloc(stack)
- Change to
LightingFrameBuffer::createFrameBuffers
doesn't actually change anything in book - Code in GLSL is listed incorrectly
- Mention removal of
updateInvMatrices
in constructor ofLightingRenderActivity
- The call
geometryRenderActivity.recordCommandBuffer(commandBuffer, meshList, scene);
and a few others doesn't actually have thescene
parameter - Mention constructor changes in
Render
class
Thanks for reprting!
Just some questions:
- Code in GLSL is listed incorrectly
Can you calrify what do you mean by this?
- Mention constructor changes in Render class
I think this is already mentioned. Can you please clarify this?