lvgl / lv_demos

Examples, tutorials and applications for the LVGL embedded GUI library

Home Page:https://lvgl.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Would a PR to update to v8.3.1 of lvgl be considered?

chmorgan opened this issue · comments

Updated lvgl from v8.1 to 8.3.1 and seeing errors due to changes in lv_obj_draw_part_dsc_t, I think a property was renamed.

I think I can fix it, would a PR to correct be something you'd consider accepting upstream?

The demos are in the main repository as of 8.2 so you shouldn't need to use this one with 8.3.

@embeddedt oh very good, should I open a PR to clarify this in the README.md? It says the repo is obsolete but doesn't say when/where. Would it make sense to flag the repo as archived to be super clear that its obsolete?

image
It seems clear to me, but if wasn't for you, probably it isn't clear for others either.

So please send a PR to update the top text. 🙂

As a reasonable time has passed since we merged the demos to lvgl we can archive this repo when your PR is merged.

Opening a PR in just a min.

@chmorgan I think you opened your PR on your own fork by accident.

Jesus, wrong repo again...

ok no, it looks ok. I thought somehow I opened against lvgl/lvgl. hah

Thanks! I will archive this repo now.