Cleanup/Improvement Items
d10sfan opened this issue · comments
d10sfan commented
-
Remove decode_as_zip and use extension check
-
switch information check to use the top level metadata (be careful to avoid expections if not exist); remove old "information" key from v2, and see if anything else should be cleaned up
-
7zip switch over
- https://github.com/dyz1990/sevenz-rust
- https://github.com/search?q=repo%3Aluxtorpeda-dev%2Fpackages%207z&type=code
- (look and see if runescape could use 7z for the deb, with extra step for tar?) - deb not supported
-
change the copy_only to automatically detect, based on not matching the last check of xz?
-
code cleanup PR (look and see feasibility of using struct) - https://github.com/luxtorpeda-dev/luxtorpeda/pull/216/files
- https://www.reddit.com/r/rust/comments/cf8w6e/how_to_find_a_value_of_struct_type_from_a_vector/
- serde default
- make sure to add setup data
- Localization i18n file instead of notice map, share client and ui js
- fix todos
- move getting from server and checking hash to function in package_metadata (only called once at start, after that call from_packages_file()); error case of from_packages_file maybe error?
- update packages UI and actions to handle new layout (and commit)
- re-test game/engine metadata features
- re-test downloading from server
- re-test user packages feature
- test source engine game, testing app id detection
-
make note in release notes that new client is required due to incompatible changes