Remove network type from Apostille class constructor parameter
aizaiz opened this issue · comments
Faiz Faidurrahman commented
@gimyboya Apostille class can get Network type from account parameter.
it's to reduce redundancy and can remove some code validation like this
if (generatorAccount.address.networkType !== networkType) {
throw new Error('network type miss matched!');
}
Al-Khawarizmi commented
this will break a lot of code knowing that it will affect the constructor, however, I think it's still relevant to fix this