Giters

luni64 / EncoderTool

The EncoderTool is a library to manage and read out rotary encoders connected either directly or via multiplexers to ARM based boards. Encoder push buttons are supported. Callback functions can be attached to encoder changes and button presses to allow for event driven applications

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Ambiguous pin assignment comments in examples

serlecu opened this issue · comments

commented

Hi,

I found really confusing these comments in the multiplexed examples.
Is there any reason why QH_A is related to the QH pin of the B register and not the A?

Multiplex 74HC165 tutorial 

constexpr unsigned QH_A = 0;   // output pin QH of shift register B
constexpr unsigned QH_B = 1;   // output pin QH of shift register A

Multiplex Callbacks tutorial 

constexpr unsigned QH_A = 2;   // output pin QH of shift register B
constexpr unsigned QH_B = 3;   // output pin QH of shift register A
commented

Is there any reason why QH_A is related to the QH pin of the B register and not the A?

Actually no, this seems to be a typo. I'll fix it. Thanks for spotting this.