luna-rs / luna

A scalable and efficient Runescape server targeting revision #377

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

GroundItem expire times are in ticks not in minutes

Nubebuster opened this issue · comments

GroundItem.java line 38-48 have the values for item expiration in minutes, but on GroundItem.java(92) the comparison is in ticks

@Nubebuster Can you provide code examples?

The lines in GroundItem.java don't match what you are saying, from my view.

Line 38-48:

/**
 * The current amount of expiration ticks.
 */
private OptionalInt expireTicks = OptionalInt.of(0);

/**
 * Creates a new {@link GroundItem}.
 *
 * @param context The context instance.
 * @param id The item identifier.

Line 92:
toString();

Excuse me,

I mean GroundItemList.java

I am trying to work with git but I am having some serious trouble. Biggest problem is that I cannot have two forks. One where I turn this into whatever game I want and another where I contribute to the pure source :( Otherwise I would do these fixes myself. Any tips?

commented

@Nubebuster Sorry for the late reply but thanks for reporting this. Also there's no workaround for this AFAIK besides using two accounts :/ GitHub limitation