lulufei / seek-for-android

Automatically exported from code.google.com/p/seek-for-android

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Synchronization on non final modifiable variable in SEService

GoogleCodeExporter opened this issue · comments

mReaders is defined as a non final private field in SEService.
The value is reset on each invocation of getReaders() (line #171)
However the code relies on mReaders for thread syncronization in shutdown code, 
while the variable can possible reset leading to a race.

In addition, onServiceDisconnected callback also syncronizes on mReaders. In 
case the user never called getReader mReaders will be equal to null leading to 
syncronization on null variable.

Original issue reported on code.google.com by kipo...@gmail.com on 6 Nov 2012 at 2:24

fixed in SCAPI-3.0.0

Original comment by Daniel.A...@gi-de.com on 15 Apr 2013 at 3:19

  • Changed state: Fixed
setting old issues from fixed to done

Original comment by Daniel.A...@gi-de.com on 5 Jul 2013 at 2:33

  • Changed state: Done