lukeed / pwa

(WIP) Universal PWA Builder

Home Page:https://pwa.cafe

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

React Installed brand new, not working straight up.

bovas85 opened this issue · comments

Repro steps

  • Use windows.
  • Install globally
  • Create a project with offline plugin, React and eslint
  • yarn build

error:

[PWA] Deleted existing build directory
(node:9852) UnhandledPromiseRejectionWarning: Error: original.line and original.column are not numbers -- you probably meant to omit the original mapping entirely and only map the generated position. If so, pass null for the original mapping instead of an object with empty or null values.
    at SourceMapGenerator_validateMapping [as _validateMapping] (C:\xxx\checkout-new\node_modules\source-map\lib\source-map-generator.js:276:15)

Node version?

@lukeed I have v10.16.0

Thanks, will boot Windows and check it out today.

It's all builds currently. Does not happen during watch command, which means it's production-specific build.

This indeed is affecting everything globally. I created a new project 2 days ago and everything works, and now that's no longer the case. It had to be upstream issue, so I ran a diff on yarn.lock files and found that terser changed.

See relevant issue: terser/terser#380

Current workaround (using yarn) is to add the following inside package.json:

  "devDependencies": {
    // ...
  },
  "resolutions": {
    "terser": "4.0.0"
  }

Closing because terser@4.0.2 was published, which reverts the offending commit.

Thanks!