Code breaks when I upgrade my angular from 8.0 to 9.0

Question

Code breaks when I upgrade my angular from 8.0 to 9.0

ashismo opened this issue 4 years ago · comments

When I upgraded my angular from 8.0 to 9.0, getting the below error. Can you please fix this?
ERROR in node_modules/ngx-gallery/ngx-gallery-helper.service.d.ts:1:22 - error TS2724: Module '"node_modules/@angular/core/core"' has no exported member 'Renderer'. Did you mean 'Renderer2'?
Can you please fix this?

Andrey Kolkov · Answer 1 · Thu Apr 09 2020 03:22:20 GMT+0800 (China Standard Time)

Hi! Try to use this version for Angular 8, 9.
https://www.npmjs.com/package/@kolkov/ngx-gallery

Ashish Mondal · Answer 2 · Thu Apr 09 2020 09:42:07 GMT+0800 (China Standard Time)

Thanks for your reply. I have used this and the same has been broken. Please see the below image.
I have the below settings. Looks like the height is not working

this.galleryOptions = [
{
width: '100%',
height: '300px',
thumbnailsColumns: 4,
imageAnimation: NgxGalleryAnimation.Slide,
previewZoom: true,
previewZoomMax: 4,
previewZoomStep: 0.4,
imageSwipe: true,
previewRotate: true,
imageDescription: true,
fullscreenIcon: 'fas fa-compress',
previewFullscreen: true,
imageArrowsAutoHide: true,
preview: true,
actions: this.gallaryActions
},
// max-width 800
{
breakpoint: 800,
width: '100%',
height: '300px',
imagePercent: 80,
thumbnailsPercent: 20,
thumbnailsMargin: 20,
thumbnailMargin: 20,
previewZoom: true,
preview: true,
actions: this.gallaryActions
},
// max-width 400
{
breakpoint: 400,
width: '100%',
height: '300px',
fullWidth: true,
imageDescription: true,
preview: true,
actions: this.gallaryActions
}
];

charlie · Answer 3 · Thu Apr 09 2020 10:38:05 GMT+0800 (China Standard Time)

Hi! Try to use this version for Angular 8, 9. https://www.npmjs.com/package/@kolkov/ngx-gallery

…

On Wed, Apr 8, 2020 at 7:42 PM Ashish Mondal ***@***.***> wrote: Thank for your reply. I have used this and the same has been broken. Please see the below image. I have the below settings. Looks like the height is not working this.galleryOptions = [ { width: '100%', height: '300px', thumbnailsColumns: 4, imageAnimation: NgxGalleryAnimation.Slide, previewZoom: true, previewZoomMax: 4, previewZoomStep: 0.4, imageSwipe: true, previewRotate: true, imageDescription: true, fullscreenIcon: 'fas fa-compress', previewFullscreen: true, imageArrowsAutoHide: true, preview: true, actions: this.gallaryActions }, // max-width 800 { breakpoint: 800, width: '100%', height: '300px', imagePercent: 80, thumbnailsPercent: 20, thumbnailsMargin: 20, thumbnailMargin: 20, previewZoom: true, preview: true, actions: this.gallaryActions }, // max-width 400 { breakpoint: 400, width: '100%', height: '300px', fullWidth: true, imageDescription: true, preview: true, actions: this.gallaryActions } ]; [image: image] <https://user-images.githubusercontent.com/11231867/78849109-8be71080-79e1-11ea-93b1-ea34de2ca7d2.png> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#309 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABS2RF6XXQHSS2RG5DOGRA3RLURXZANCNFSM4MEFCOKA> .

Andrey Kolkov · Answer 4 · Thu Apr 09 2020 11:31:28 GMT+0800 (China Standard Time)

Thanks for your reply. I have used this and the same has been broken. Please see the below image.
I have the below settings. Looks like the height is not working

this.galleryOptions = [
{
width: '100%',
height: '300px',
thumbnailsColumns: 4,
imageAnimation: NgxGalleryAnimation.Slide,
previewZoom: true,
previewZoomMax: 4,
previewZoomStep: 0.4,
imageSwipe: true,
previewRotate: true,
imageDescription: true,
fullscreenIcon: 'fas fa-compress',
previewFullscreen: true,
imageArrowsAutoHide: true,
preview: true,
actions: this.gallaryActions
},
// max-width 800
{
breakpoint: 800,
width: '100%',
height: '300px',
imagePercent: 80,
thumbnailsPercent: 20,
thumbnailsMargin: 20,
thumbnailMargin: 20,
previewZoom: true,
preview: true,
actions: this.gallaryActions
},
// max-width 400
{
breakpoint: 400,
width: '100%',
height: '300px',
fullWidth: true,
imageDescription: true,
preview: true,
actions: this.gallaryActions
}
];

Do you have this class?
kolkov/ngx-gallery#8

charlie · Answer 5 · Thu Apr 09 2020 11:49:14 GMT+0800 (China Standard Time)

Did you upgrade from this repository? https://github.com/kolkov/ngx-gallery It worked for me with angular 9.1. Cheers

…

On Wed, Apr 8, 2020 at 9:31 PM Andrey Kolkov ***@***.***> wrote: Thanks for your reply. I have used this and the same has been broken. Please see the below image. I have the below settings. Looks like the height is not working this.galleryOptions = [ { width: '100%', height: '300px', thumbnailsColumns: 4, imageAnimation: NgxGalleryAnimation.Slide, previewZoom: true, previewZoomMax: 4, previewZoomStep: 0.4, imageSwipe: true, previewRotate: true, imageDescription: true, fullscreenIcon: 'fas fa-compress', previewFullscreen: true, imageArrowsAutoHide: true, preview: true, actions: this.gallaryActions }, // max-width 800 { breakpoint: 800, width: '100%', height: '300px', imagePercent: 80, thumbnailsPercent: 20, thumbnailsMargin: 20, thumbnailMargin: 20, previewZoom: true, preview: true, actions: this.gallaryActions }, // max-width 400 { breakpoint: 400, width: '100%', height: '300px', fullWidth: true, imageDescription: true, preview: true, actions: this.gallaryActions } ]; [image: image] <https://user-images.githubusercontent.com/11231867/78849109-8be71080-79e1-11ea-93b1-ea34de2ca7d2.png> Do you have this class? kolkov/ngx-gallery#8 <kolkov/ngx-gallery#8> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#309 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABS2RFYRDFLBTOKYYDIAQ53RLU6RZANCNFSM4MEFCOKA> .

saifansari2 · Answer 6 · Mon Apr 27 2020 00:21:16 GMT+0800 (China Standard Time)

https://github.com/kolkov/ngx-gallery

this is not working with dynamic binding with api post response

static binding is working fine

saifansari2 · Answer 7 · Mon Apr 27 2020 22:47:57 GMT+0800 (China Standard Time)

it is not working with .webp format