luckyframework / lucky_cli

There's a few spots that use Int64 and assumes that is the User's ID type, but we can use User::PrimaryKeyType instead which will resolve as Int64 or UUID... or really whatever you're using.

Taking a look at this one doesn't seem to be as straight forward as just using that type all over. There's a few spots where we treat the id as a String, then cast it with to_i64. My first thought is we'd need some sort of cast_to_primary_key type method which could have string.to_i64, then just have 1 spot you change this and it works everywhere...

Then again... I know you can do .id("4") in Avram, and it handles it on its own.. Maybe we just allow the String version to be passed around since that works for both Ints and UUID?

If anyone else wants to look in to this, here's a few of the files that need looking at. I may have missed some

lucky_cli/src/browser_authentication_app_skeleton/src/pages/password_resets/new_page.cr

Line 3 in 9fb2011

needs user_id : Int64

lucky_cli/src/api_authentication_app_skeleton/src/models/user_token.cr

Lines 16 to 18 in 9fb2011

    
           def self.decode_user_id(token : String) : Int64? 
        
             payload, _header = JWT.decode(token, Lucky::Server.settings.secret_key_base, ALGORITHM) 
        
             payload["user_id"].to_s.to_i64

lucky_cli/src/browser_authentication_app_skeleton/src/actions/password_resets/create.cr

Line 13 in 9fb2011

html NewPage, operation: operation, user_id: user_id.to_i64

lucky_cli/src/browser_authentication_app_skeleton/src/actions/password_resets/edit.cr

Line 6 in 9fb2011

html NewPage, operation: ResetPassword.new, user_id: user_id.to_i64

	def self.decode_user_id(token : String) : Int64?
	payload, _header = JWT.decode(token, Lucky::Server.settings.secret_key_base, ALGORITHM)
	payload["user_id"].to_s.to_i64

Use User::PrimaryKeyType all over