:clean-on-unmount? broken or vestigial

Question

:clean-on-unmount? broken or vestigial

psagers opened this issue 4 years ago · comments

The :clean-on-unmount? option under re-frame ends up dispatching the :fork.re-frame/clean event, which is not registered. It looks like the option may be obsolete, although some app-db cleanup may still be warranted.

Thanks

Lucio D'Alessandro · Answer 1 · Thu Jul 09 2020 23:14:14 GMT+0800 (China Standard Time)

Besides the fact that the on clean event doesn’t exist anymore, I was thinking about whether we should still support the component-will-unmount Lifecycle method, as react deprecated it in favour of useEffect.

Lucio D'Alessandro · Answer 2 · Sat Jul 11 2020 17:11:43 GMT+0800 (China Standard Time)

I removed clean-on-unmount? in v2.0.1, as react doesn't support component-will-unmount anymore.

Peter Sagerson · Answer 3 · Sun Jul 12 2020 01:43:46 GMT+0800 (China Standard Time)

Out of curiosity, could you link to a reference to React dropping support for componentWillUnmount? I see that they've deprecated componentWillMount, but I can't find any references to deprecating componentWillUnmount.

Thanks

Lucio D'Alessandro · Answer 4 · Sun Jul 12 2020 05:01:34 GMT+0800 (China Standard Time)

Oh my! It's not deprecated, you are right! I shouldn't work when I am too tired :) I'll revert.

Lucio D'Alessandro · Answer 5 · Sun Jul 12 2020 05:09:50 GMT+0800 (China Standard Time)

If you pull v2.0.2 it should work properly now. Let me know :)