lucidrains / alphafold2

To eventually become an unofficial Pytorch implementation / replication of Alphafold2, as details of the architecture get released

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Typo?

CiaoHe opened this issue · comments

Hi Phil and Eric @hypnopump

I'm not familiar with the operations on protein structure or whatever :(, but here I wonder is it a mistake when indexing:

new_coords[:, :-padding or None, i] = coords[:, i]

Perhaps it should be new_coords[s,:-padding or None, i] since in the inner loop it just constructs the s-th sequence sidechain's coords.

Best,

Oh yes! Hidden bug (the function was only used with one sequence so the error ran unnoticed).

In general, the utils need an update (which i do have locally but havent pushed). I'll be updating them in the following days.

Oh yes! Hidden bug (the function was only used with one sequence so the error ran unnoticed).

In general, the utils need an update (which i do have locally but havent pushed). I'll be updating them in the following days.

Thanks a lot eric!

@CiaoHe thanks for all the code reviews!