infinite loop update check
sq787 opened this issue · comments
In some cases, LibreWolf version notation in Releases and the program do not match. So, even after completing the update to the current version, it continues to incorrectly recognize the current version as a new version.
e.g.)
- Versions on Releases: 99.0.1.2
- Internally indicated version: 99.0.1-4
Thanks for reporting. Yes, the versioning used by LibreWolf is inconsistent, so it's difficult to compare the installed version with the version in the release file. As you state, there's 99.0.1.2, 99.0.1-4 and 99.0.1.8154, all for the exact same release (and sometimes the Releases page uses the -4, and sometimes the .2 notation).
So, I've added an extra check to compare the current version in the release file as downloaded from Gitlab with the version number WinUpdater saves to its ini-file, if it updated successfully, which now has the version formatting of the release file, not of the exe-file. This allows for the extra check and should prevent the infinite update loop.
Could you have a look at the latest release and test it?
NOTE: It will download and "update" one more time before it will exit the update loop.
Great!👍
I do hate the idea of "an updater needing updates", though 😅 And unfortunately, the updater isn't bundled with e.g. the LibreWolf portable zip-file, so it won't be fixed for users automatically via a LibreWolf update. Ah well, it's an imperfect world.
Well, it survived the "versioning mess" as stanzabird called it himself, so I guess we know this is fully fixed 😛