Some extensions don't have a node list in `extension-node-map.json`
liusida opened this issue · comments
I was inspired by https://ltdrdata.github.io/ and have integrated the data from extension-node-map.json to my top-100-comfyui, but I found that it shows that many extensions don't have nodes, for example:
==
![image](https://private-user-images.githubusercontent.com/14249458/336863374-395d74b9-51a8-4181-bcc7-d7755f667508.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA2MDY1MjIsIm5iZiI6MTcyMDYwNjIyMiwicGF0aCI6Ii8xNDI0OTQ1OC8zMzY4NjMzNzQtMzk1ZDc0YjktNTFhOC00MTgxLWJjYzctZDc3NTVmNjY3NTA4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEwVDEwMTAyMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZiYjU1MjliMDg3Zjg5Mjg4OTc3OGY2ODdkMGIwOTUyY2M5MjgxZTZjYjBmNDkyYzkwYmVhZDc2ZGI3M2VkYTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.KLZLk0zdwXCrjm6cobk9Vaod2DyHcJZUVSGOfbcQl_c)
And I looked it up in the original file, it doesn't contain any nodes as well:
"https://github.com/rgthree/rgthree-comfy": [
[],
{
"author": "rgthree",
"description": "A bunch of nodes I created that I also find useful.",
"nickname": "rgthree",
"nodename_pattern": " \\(rgthree\\)$",
"title": "Comfy Nodes",
"title_aux": "rgthree's ComfyUI Nodes"
}
],
And also https://ltdrdata.github.io/
I think this might be caused by a problem in the information collecting process. Would you like to take a look at it? Thanks!
That is a limitation.
https://github.com/ltdrdata/ComfyUI-Manager#custom-node-support-guide
The node names are collected by the scanner.py
script.
Since it is a script that scans statically, it is not possible to collect node names that are generated dynamically or exist virtually on the JavaScript side.
For those nodes, unless the list is explicitly provided, ComfyUI-Manager cannot provide them either.
Managing those nodes through code review is beyond my capacity.