lsds / sgx-lkl

We currently unmount the root file system using the MNT_DETACH option, otherwise we sometimes observe hanging behaviour (despite the timeout):

sgx-lkl/src/lkl/setup.c

Line 1276 in a1fb63f

res = lkl_umount_timeout("/", MNT_DETACH, UMOUNT_DISK_TIMEOUT);

We should check that this always cleanly unmounts the file systems and does not lead to data loss. It also not clear that the code correctly unmounts the entire file system hierarchy.

do we know if any tests hit this issue?
Does it need to be fixed by September? I am assuming not.

Didn't @jxyang report that he wrote to a file in the root file system, and this wasn't persisted across SGX-LKL restarts? We should add a CI test that checks that we are persisting root file system changes correctly.

@prp I believe you mean: #713

anyone think this is not p2?

File systems unmounted using MNT_DETACH may become inconsistent